[AWFFULL] Patch for beta3 issues

Oden Eriksson oeriksson at mandriva.com
Tue Nov 18 03:02:58 EST 2008


Den Saturday 15 November 2008 06:43:30 skrev Steve McInerney:
> All,
>
> the attached patch fixes the two issues that have come out so far.
> 1. Being the floating point exception Oden found
> 2. Being the weirdness Eric (Woudenberg) reported.
>
> Both were fundamentally due to poor assumptions on my part in setting
> values that were either bad, or subject to later vagaries. :-(
>
> Eric's was a truly fascinating case. And is probably why it's taken so long
> for the situation to be brought to light.
> In essence - the data in a sample log he sent through is badly timestamped.
> The logs are nicely sorted - IF you include the TZ. But in the same log are
> TWO different TZ's separated by about 3 hours - which doesn't work too well
> with awffull as is - as the assumption is made that all data in the log is
> in a single TZ.
>
> So that caused part of the flip-flopping, the other was caused by the
> assumption above, and the bad data - in that the "previous time" value
> would get set irrespective of whether the previous time was actually good
> or bad. == FAIL.
>
>
> So, subject to external pressures, I'll give this patch a few days, and if
> no one else ... complains :-) I'll roll out as v3.9.1 final.
> The only other changes since 3.9.1-b3 are all text or cosmetic.
>
> As ever, the bzr aware among you can grab the latest from:
> $ bzr lp:awffull
>
> Cheers!
> - Steve

beta3 + this patch is now in mandriva cooker.

-- 
Regards // Oden Eriksson



More information about the AWFFull mailing list